Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup applayer: update copyright years in files #5817

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

setup applayer script: update copyright year to 2021 in template files
used by the script

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

  • there isn't one

Describe changes:

  • setup applayer script: update copyright year to 2021 in template files used by the script

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

setup applayer script: update copyright year to 2021 in template files
used by the script
@jufajardini jufajardini requested review from jasonish, victorjulien and a team as code owners February 4, 2021 14:03
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #5817 (8841f08) into master (62e665c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5817   +/-   ##
=======================================
  Coverage   72.38%   72.39%           
=======================================
  Files         604      604           
  Lines      179369   179369           
=======================================
+ Hits       129837   129850   +13     
+ Misses      49532    49519   -13     
Flag Coverage Δ
suricata-verify 49.16% <ø> (+0.01%) ⬆️
unittests 63.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

/* Copyright (C) 2018 Open Information Security Foundation
/* Copyright (C) 2021 Open Information Security Foundation
Copy link
Member

@jasonish jasonish Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the model we follow would have this be 2018-2021. The idea is that the first year is the year of creation, and the second year is the year of the last modification, in a sense to extend the copyright out from the most recent modification.

While legally the year specified is doesn't matter at all, I think we should remain consistent for what its worth.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you, I wondered why some had two years while others had just one. I'll fix that.

@jufajardini
Copy link
Contributor Author

Closed with: #5823

@jufajardini jufajardini closed this Feb 5, 2021
@jufajardini jufajardini deleted the nit-setup-applayer-v0 branch January 11, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants