Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: initial support (MVP) #5832

Closed

Conversation

jufajardini
Copy link
Contributor

PostgreSQL: add SSL handshake support
-- applayerpgsql/parser: add parsers for request and response messages
-- applayerpgsql/pgsql: add unittests for parse_response
-- this parser does not yet handle what happens after the handshake

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4241

Previous PR (draf): #5830

Describe changes:

  • applayerpgsql/parser: add parsers for request and response messages
  • applayerpgsql/pgsql: add unittests for parse_response
  • this parser does not yet handle what happens after the handshake
  • fix inconsistency with ALPROTO_PGSQL in some places and ALPROTO_POSTGRESQL in others

#suricata-verify-pr: OISF/suricata-verify#433
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

PostgreSQL: add SSL handshake support
-- applayerpgsql/parser: add parsers for request and response messages
-- applayerpgsql/pgsql: add unittests for parse_response
-- this parser does NOT yet handle what happens after the handshake
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #5832 (eacb800) into master (62e665c) will decrease coverage by 0.00%.
The diff coverage is 59.75%.

@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
- Coverage   72.38%   72.38%   -0.01%     
==========================================
  Files         604      606       +2     
  Lines      179369   179452      +83     
==========================================
+ Hits       129837   129891      +54     
- Misses      49532    49561      +29     
Flag Coverage Δ
suricata-verify 49.16% <58.02%> (+0.01%) ⬆️
unittests 63.05% <14.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini
Copy link
Contributor Author

Closed with: #5841

@jufajardini jufajardini deleted the pgsql-mvp-ssl-handshake-v2 branch January 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant