-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devguide: recommend using rustup to install rust - v1 #9612
Conversation
We were still instructing that rust and cargo were installed via apt. Update the instructions to follow what is recommended by Rust community themselves.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9612 +/- ##
==========================================
- Coverage 82.28% 82.26% -0.03%
==========================================
Files 968 968
Lines 274275 274275
==========================================
- Hits 225700 225640 -60
- Misses 48575 48635 +60
Flags with carried forward coverage won't be shown. Click here to find out more. |
I disagree with this change. We should use the distro packages unless there is a reason they are insufficient. |
Invoking @jasonish in case he has strong opinions on this '-' |
Target audience. For end users installing from git, we should use the packages. For developers installing from git, rustup is probably the best. Its the only way to install/test different versions of Rust, which could be a reason for CI failure, etc. This is in the developers guide, not the user install guide. |
I disagree. We also don't recommend installing your own C compiler or specific versions of libc. Rust packaging has come along far enough that we can use it in development. I think it's fine to have a section to explain benefits of using a more recent version, but not claim it's needed or recommended. |
Its not there yet. Want clippy, Likewise, we're likely to request changes on a commit that doesn't pass the lints in CI, which might require a user to change to a specific version of rust. Trivial with rustup. None of this is about using a more recent version. |
Closing as we haven't agreed upon the best approach, here. |
During Outreachy onboarding, we noticed that we weren't referring to rust installation via rustup, in our devguide.
Describe changes:
apt