-
-
Notifications
You must be signed in to change notification settings - Fork 468
fix(comments): align comment box height and font with design #4590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comments): align comment box height and font with design #4590
Conversation
- Set font-family to Inter and font-size to 16px to match published comments - Change rows from 2 to 1 to reduce initial height - Add mobile media query for responsive height alignment Fixes ONEARMY#4432 Co-authored-by: Cursor <[email protected]>
|
This is my first open source contribution! Happy to make any changes if needed. |
|
Heey @rsgb, thanks for this! Looks good on the preview branch, merging. |
|
@all-contributors add @rsgb for code |
|
I've put up a pull request to add @rsgb! 🎉 |
|
Hey @mariojsnunes , thanks for the quick review! Also noted: will add screenshots next time, when changing UI! |
|
🎉 This PR is included in version 2.105.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Notes
On mobile, font-size is reduced to 12px to match the 40px button height. This prioritizes height alignment over font consistency on mobile screens.
Fixes #4432
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes
Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #
What happens next?
Thank you for the contribution! We will review it ASAP.
If you need more immediate feedback you can reach out to us on Discord in the Community Platform
developmentchannel.