Skip to content

Conversation

@mariojsnunes
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

  • fix "load more" news button not showing
  • properly paginate considering user badges

reduced empty space:
image

image

Fixed button alignment:
image

Fixed breadcrumbs crop:
image

image

Technical Changes

  • Removed ListHeader from News - was causing more trouble than it's worth. /cc @benfurber
  • Added const { isUserAuthorized } = useProfileStore(); a new store function to check current user roles. This is useful when the <AuthWrapper> is overkill.

Does this PR introduce a DB Schema Change or Migration?

  • No

@cypress
Copy link

cypress bot commented Jan 30, 2026

onearmy-community-platform    Run #8457

Run Properties:  status check failed Failed #8457  •  git commit 066fea0e80: fix unit test
Project onearmy-community-platform
Branch Review feat/news-pagination
Run status status check failed Failed #8457
Run duration 07m 49s
Commit git commit 066fea0e80: fix unit test
Committer Mário Nunes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 93
View all changes introduced in this branch ↗︎

Tests for review

Failed  src/integration/research/discussions.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Research.Discussions] > allows users to sort comments Test Replay Screenshots Video
Flakiness  settings.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Settings] > Can create member Test Replay Screenshots Video
Flakiness  questions/discussions.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Questions.Discussions] > allows users to sort comments Test Replay Screenshots Video
Flakiness  research/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
... > [Delete button is visible] Test Replay Screenshots Video

@mariojsnunes mariojsnunes merged commit fc84ee2 into master Jan 30, 2026
10 of 12 checks passed
@mariojsnunes mariojsnunes deleted the feat/news-pagination branch January 30, 2026 14:45
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Core Team - BAU list Jan 30, 2026
jproberson pushed a commit that referenced this pull request Jan 30, 2026
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.105.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants