Skip to content

feat: refactor room joining logic and implement InRoomWrapper for use… #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
04shubham7 merged 1 commit into from
Nov 12, 2025
Merged

feat: refactor room joining logic and implement InRoomWrapper for use… #71

04shubham7 merged 1 commit into from
Nov 12, 2025

Conversation

@Shreyanshi210205
Copy link
Contributor

@Shreyanshi210205 Shreyanshi210205 commented Nov 10, 2025 •
edited by 04shubham7
Loading

…r authentication

Description

I have established the socket connection inside the InRoom.tsx and removed the placeholder for peer . Made changes in the UI to make the InRoom.tsx visually appealing to the user for example showing the room name , their usernames etc. I have established the connection and accordingly to the chat-messages too.

WhatsApp Image 2025-11-10 at 10 15 01_7f161e5b
WhatsApp Image 2025-11-10 at 10 03 43_695ce659

Semver Changes

  • Patch (bug fix, no new features)
  • Minor (new features, no breaking changes)
  • Major (breaking changes)

Issues

#66

Checklist

@04shubham7 04shubham7 linked an issue Nov 12, 2025 that may be closed by this pull request
[Feature]: Establish socket connection when a user enters the room from the room lobby . #66
Closed
1 task
04shubham7
04shubham7 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@04shubham7 04shubham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Fine

@04shubham7 04shubham7 merged commit 921ebf0 into OPCODE-Open-Spring-Fest:main Nov 12, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@04shubham7 04shubham7 04shubham7 approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted PR:Accept Semver:minor Type:Medium medium level issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Establish socket connection when a user enters the room from the room lobby .

2 participants

@Shreyanshi210205 @04shubham7