Skip to content

Replace MDI window system with docking#14095

Merged
jonjenssen merged 52 commits into
devfrom
mdi_testing
Jun 17, 2026
Merged

Replace MDI window system with docking#14095
jonjenssen merged 52 commits into
devfrom
mdi_testing

Conversation

@jonjenssen

@jonjenssen jonjenssen commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Closes #759
Closes #14056

@jonjenssen
jonjenssen force-pushed the mdi_testing branch 2 times, most recently from b783282 to 0444b20 Compare June 9, 2026 10:42
@jonjenssen
jonjenssen marked this pull request as ready for review June 11, 2026 15:26
@jonjenssen
jonjenssen marked this pull request as draft June 16, 2026 09:59
@jonjenssen
jonjenssen marked this pull request as ready for review June 16, 2026 14:30

@kriben kriben left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested on Ubuntu, and worked well.

{
if ( auto view = dynamic_cast<Rim3dView*>( caf::SelectionManager::instance()->selectedItem() ) )
{
if ( ( view->showWindow() ) && ( !view->isDockedInPlotView() ) )

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra parens here?

@magnesj

magnesj commented Jun 17, 2026

Copy link
Copy Markdown
Member

Tested on Mac, and there are issues related to dragging.

@jonjenssen

Copy link
Copy Markdown
Collaborator Author

Tested on Mac, and there are issues related to dragging.

Added as new issue #14234

@jonjenssen
jonjenssen merged commit 576fb32 into dev Jun 17, 2026
21 checks passed
@jonjenssen
jonjenssen deleted the mdi_testing branch June 17, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snapshots: update view snapshot system after MDI is removed Migrate center windows from MDI to dock windows

3 participants