Fix empty pointMapping_ when synchrCellIds in adapt() calls #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritorto
added
the
manual:irrelevant
Member
Author
|
jenkins build this serial please |
blattms
reviewed
Aug 20, 2025
Member
blattms
left a comment
blattms
left a comment
There was a problem hiding this comment.
Thanks a lot.
Nice catch. Just a small typo in the comment.
Member
Author
|
jenkins build this serial please |
Co-authored-by: Markus Blatt <[email protected]>
Member
Author
|
jenkins build this serial please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #898 avoids implicit derived-to-base conversion (use Entity instead of EntityRep) by overloading id with explicit types Entity, codim = 0 and 3, ensuring the correct ids are used for Entity<0> and Entity<3> in CpGrid with LGRs.
To ensure that IDs are correctly handled in all possible refinement scenarios, one of the test cases invokes adapt() in both the global and distributed views, followed by synchronization of cell IDs. This is where the issue with an empty pointMapping_ arose. This PR provides a fix for it.