Refactor TargetCalculator #6626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonhagland
added
the
manual:irrelevant
Contributor
Author
|
jenkins build this please |
hakonhagland
force-pushed
the
fix_group_target
branch
from
eb6d568 to
956f23a
Compare
Contributor
Author
|
jenkins build this please |
hakonhagland
force-pushed
the
fix_group_target
branch
from
956f23a to
e05e5ee
Compare
Contributor
Author
|
jenkins build this please |
hakonhagland
force-pushed
the
fix_group_target
branch
from
e05e5ee to
969448b
Compare
Contributor
Author
|
jenkins build this please |
blattms
reviewed
Dec 11, 2025
Comment on lines
1989
to
1993
| GroupState<Scalar> empty_group_state; | ||
| auto& group_state = solving_with_zero_rate |
Member
There was a problem hiding this comment.
I don't see a reason to remove the const here. Please keep it. It might prevent unexpected changes
Comment on lines
178
to
179
| const GroupStateHelperType& groupStateHelper, | ||
| DeferredLogger& deferred_logger) override; // should be const? |
Member
There was a problem hiding this comment.
Nitpick: Indentation is a bit off.
hakonhagland
force-pushed
the
fix_group_target
branch
from
969448b to
1056857
Compare
Contributor
Author
|
jenkins build this please |
Refactor TargetCalculator::groupTarget() to WellGroupHelper::getProductionGroupTarget(), and don't pass Group::ProductionControls as a parameter. Since TargetCalculator only works for a given group, passing control as a parameter is confusing and can be error prone if being passed a control for a different group than the TargetCalculator was constructed for.
Added a comment explaining why we cannot push a const group state to GroupStateHelper
hakonhagland
force-pushed
the
fix_group_target
branch
from
1056857 to
823abc8
Compare
Contributor
Author
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
TargetCalculator::groupTarget()andInjectionTargetCalculator::groupTarget()toWellGroupHelper::getProductionGroupTarget(), andWellGroupHelper::getInjectionGroupTarget(). This will be used by reservoir coupling to compute master group targets. Also avoid passingGroup::ProductionControlsas a parameter to these methods. SinceTargetCalculatoris constructed with a single group in mind, passingcontrolas a parameter is confusing and can be error prone if being passed a control for a different group than theTargetCalculatorwas constructed for. This means thatTargetCalculatorneeds aWellGroupHelperreference, which led to a changes in 20 other files to support passing WellGroupHelper around to different methods that useTargetCalculator.