Skip to content

Conversation

@aritorto
Copy link
Member

@aritorto aritorto commented Nov 28, 2025

With this PR, together with OPM/opm-grid#955, the simulation for input files containing CARFIN blocks can be ran with the flags:
--parsing-strictness=low
--enable-ecl-output=true
--enable-vtk-output=true
The *.EGRID then is generated and can be visualized with ResInsight. Warning: Some properties might need to be corrected.

This PR calls methods from opm-grid that compute the COORD and ZCORN for level grids via the geometries. This approach will be replaced by computations based on the input file in opm-common: PR OPM/opm-common#4839 and OPM/opm-common#4843.

@aritorto aritorto added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Nov 28, 2025
@aritorto aritorto marked this pull request as draft November 28, 2025 13:58
@aritorto aritorto force-pushed the setLgrRefinementCall branch 5 times, most recently from cc8478f to 4f6bf5b Compare December 1, 2025 07:36
@aritorto aritorto changed the title Pass COORD and ZCORN lgrs to output grid - attempt Support simulation with CARFIN enabling ecl output Dec 4, 2025
@aritorto aritorto force-pushed the setLgrRefinementCall branch from c27a773 to 5894230 Compare December 4, 2025 07:27
@aritorto aritorto force-pushed the setLgrRefinementCall branch 4 times, most recently from ad4afc5 to 2b7312a Compare December 9, 2025 07:47
@aritorto aritorto marked this pull request as ready for review December 9, 2025 08:19
@aritorto aritorto force-pushed the setLgrRefinementCall branch from c94df0a to e456304 Compare December 15, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant