Dont use BHP/THP from previous shut wells

[totto82]

During well testing, we want (and need) a reasonable bhp/thp/temperature in the well.

[totto82]

jenkins build this failure_report please

[totto82]

jenkins build this failure_report please

[GitPaean]

Thanks for the request, can you give some more details about the scenario that the master branch will fail before I can review and comment on this?

[totto82]

With #6653 we use the bhp during well testing to compute IPR to be used for gaslift optimization.

[GitPaean]

The PR has some good points, while with the function defined as follows,

template<typename Scalar, typename IndexTraits>
void SingleWellState<Scalar, IndexTraits>::init_timestep(const SingleWellState& other)
{
    if (this->producer != other.producer)
        return;

    if (this->status == Well::Status::SHUT)
        return;

    if (other.status == Well::Status::SHUT)
        return;

    this->bhp = other.bhp;
    this->thp = other.thp;
    this->temperature = other.temperature;
}

I do not understand how the bhp/thp and temperature are copied from the previously SHUT well?

[totto82]

I do not understand how the bhp/thp and temperature are copied from the previously SHUT well?

Neither do I. @GitPaean, Thank you for reading the PR carefully enough to spot it.