make more files gpu-compatible #6676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multitalentloes
added
the
manual:irrelevant
akva2
reviewed
Dec 11, 2025
| const IntensiveQuantities& intQuantsEx, | ||
| const unsigned phaseIdx, | ||
| const ConvectiveMixingModuleParam& info) { | ||
| FluidSystem fsys = intQuantsIn.getFluidSystem(); |
Member
Author
There was a problem hiding this comment.
I'll add const refs, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make blackoilconvectivemixing module and newtranfluxmodule gpu-compatible.
This includes extracting the moduleparams struct so that it can be templated more easily with gpubuffers, other stuff is mostly just adding the function decorators for cuda/hip to make the functions accessible during gpu execution.
Depends on OPM/opm-common#4865
This pr is based on extracting some of the changes in #6612 to make the review less noisy