Move linear system export and make it safer. #6677
Draft
+146
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the print...() functions that only wrote partial information. If this is needed it may be done by extracting from the export...() output instead. - Move the export...() functions to a separate file. Keeping the top-level function though, and the logic it contained relating to avoiding re-writing the sparsity pattern. - Make the implementation safer by removing all use of sprintf().
atgeirr
added
the
manual:irrelevant
Member
Author
|
@nrseman any comments? |
Member
Author
|
jenkins build this please |
Looks like a reasonable solution to me. Did you verify that it works? |
|
@atgeirr, did you have a chance to verify that the export functionality still works? |
Member
Author
Not yet, will try to get it done this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to remove unrelated export functionality from the linearization class, and avoid sprintf() which generates tons of warnings on clang.