Skip to content

Bugfix: groupStateHelper uses potentially wrong WellState #6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blattms merged 1 commit into from
Dec 12, 2025
+5 −3
Merged

Bugfix: groupStateHelper uses potentially wrong WellState #6679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions opm/simulators/wells/WellInterface_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2202,9 +2202,11 @@ namespace Opm
OPM_TIMEFUNCTION();
WellStateType well_state_copy = well_state;
const auto& groupStateHelper = simulator.problem().wellModel().groupStateHelper();
GroupStateHelperType groupStateHelper_copy = groupStateHelper;
auto well_guard = groupStateHelper_copy.pushWellState(well_state_copy);
const double dt = simulator.timeStepSize();
const bool converged = this->solveWellWithBhp(
simulator, dt, bhp, groupStateHelper, well_state_copy, deferred_logger
simulator, dt, bhp, groupStateHelper_copy, well_state_copy, deferred_logger
);

bool zero_rates;
Expand All @@ -2216,9 +2218,9 @@ namespace Opm
// For zero rates or unconverged bhp the implicit IPR is problematic.
// Use the old approach for now
if (zero_rates || !converged) {
return this->computeBhpAtThpLimitProdWithAlq(simulator, groupStateHelper, summary_state, alq_value, deferred_logger, /*iterate_if_no_solution */ false);
return this->computeBhpAtThpLimitProdWithAlq(simulator, groupStateHelper_copy, summary_state, alq_value, deferred_logger, /*iterate_if_no_solution */ false);
}
this->updateIPRImplicit(simulator, groupStateHelper, well_state_copy, deferred_logger);
this->updateIPRImplicit(simulator, groupStateHelper_copy, well_state_copy, deferred_logger);
this->adaptRatesForVFP(rates);
return WellBhpThpCalculator(*this).estimateStableBhp(well_state_copy, this->well_ecl_, rates, this->getRefDensity(), summary_state, alq_value);
}
Expand Down