Bugfix: Use correct efficiency factor when adding back local reduction contribution in group constraint checking #6681
+830
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test exposes a bug in GroupStateHelper::checkGroupConstraintsProd() where the addback calculation uses the accumulated efficiency factor instead of the partial efficiency factor at local_reduction_level. Test setup: - Group hierarchy: FIELD -> PLAT (E=0.9) -> MANI (E=0.8) / MANI2 (E=0.7) - MANI has individual ORAT control, PLAT has guide rate - WELL-A produces 10000 SM3/day under MANI The bug causes: - Addback uses 0.72 (E_MANI * E_PLAT) instead of 0.8 (E_MANI) - This results in scale = 0.9465 (false constraint violation) - Correct calculation would give scale = 1.0288 (no violation) The test currently passes with the buggy expected values. A subsequent commit will fix the bug and update the test expectations.
hakonhagland
added
manual:irrelevant
Contributor
Author
|
jenkins build this please |
1 similar comment
Contributor
Author
|
jenkins build this please |
The addback calculation at local_reduction_level was using the accumulated efficiency factor (from entity to control group) instead of the partial efficiency factor (from entity to local_reduction_level). This caused incorrect constraint violations when checking higher-level group constraints. The fix computes the partial efficiency by multiplying efficiency factors from local_reduction_level down to the entity.
hakonhagland
force-pushed
the
fix_eff_factor
branch
from
6653b6e to
da720e1
Compare
Contributor
Author
|
jenkins build this please |
totto82
approved these changes
Dec 17, 2025
Member
totto82
left a comment
totto82
left a comment
There was a problem hiding this comment.
Nice catch! Also, thanks for adding a test. I did not see any issues in the code. If there are no other comments from others, I will merge this later today.
Member
|
I am not reviewing the PR. Just want to make sure Jenkins runs fine. |
Member
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the efficiency factor addback part of the group constraint checking. The addback calculation at
local_reduction_levelwas using the accumulated efficiency factor (from entity to control group) instead of the partial efficiency factor (from entity tolocal_reduction_level).This might cause incorrect constraint violations when checking higher-level group constraints. The fix computes the partial efficiency by multiplying efficiency factors from
local_reduction_leveldown to the entity. Also added a test case to demonstrate the issue, see the first commit of this PR.