Skip to content

Conversation

@bska
Copy link
Member

@bska bska commented Dec 15, 2025

Uses the example models provided in PR OPM/opm-tests#1441.

These are INIT file only tests because the simulation models in the two example cases aren't particularly interesting.

@bska bska added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Dec 15, 2025
@bska bska force-pushed the operate-work-init-tests branch from 1dc5fbf to da60977 Compare December 15, 2025 13:06
@bska bska marked this pull request as draft December 15, 2025 13:07
@bska
Copy link
Member Author

bska commented Dec 15, 2025

I'm resetting this PR back to draft mode pending resolution of #6685.

Uses the example models provided in PR OPM/opm-tests#1441.

These are INIT file only tests because the simulation models in
the two example cases aren't particularly interesting.
@bska bska force-pushed the operate-work-init-tests branch from da60977 to 9789b80 Compare December 15, 2025 14:43
@bska
Copy link
Member Author

bska commented Dec 15, 2025

I'm resetting this PR back to draft mode pending resolution of #6685.

The prerequisite PR has been merged into the master branch so I'm marking this PR that leverages the "multiple tests" macros as "ready for review".

@bska bska marked this pull request as ready for review December 15, 2025 14:44
@bska
Copy link
Member Author

bska commented Dec 15, 2025

Note that as these are new tests, we'll have to generate new reference solutions for them.

@bska
Copy link
Member Author

bska commented Dec 15, 2025

jenkins build this update_data please

@bska
Copy link
Member Author

bska commented Dec 15, 2025

update_data

Generated OPM/opm-tests#1445 which does not have any new/updated reference solution files so I'm probably doing something wrong. Any guesses/hints, @akva2?

@akva2
Copy link
Member

akva2 commented Dec 15, 2025

the norne init test is not part of the regular updates, but rather a special case. should probably add an elseif for compareECLInitFiles further up.

@bska
Copy link
Member Author

bska commented Dec 16, 2025

should probably add an elseif for compareECLInitFiles further up.

Right. Unless you're already doing something here, I'd like to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants