Add option for drift compensation for TEMP #6684
Open
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compensate for mass loss in the energy equation to avoid unphysical temperatures Activated by default --enable-droft-compensation-temp (Default = true)
totto82
added
manual:new-feature
Member
Author
|
jenkins build this please |
Member
|
Maybe this option should be decoupled from using it in the flow simulation i.e. separate options. It is a good idea to include this in the separate temperature solve, since it avoid a lot of unphysical solutions when flow is not sufficiently accurate, even if one do not use driftcompansation for flow i.e. pressure and fluidphase transport, where it may lead to strange results. |
Member
Author
Agree. That is what I do in this PR. By default --enable-drift-compensation is false while --enable-drift-compensation-temp is true if TEMP is activated. (Or at-least that was the intention) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compensate for mass loss in the energy equation to avoid unphysical temperatures. Activated by default --enable-droft-compensation-temp (Default = true)