Add support for Pennylane Lightning backend to QIR-EE #28
Conversation
which was accidentally copied into the top level
Remark: Compares only empty output for now until we find a way to properly store the result and not just print as we go. Temporarily using lowercase qsim. Will modify class names later with the others at the same time.
This commit will fail tests since I am documenting the file name change separately.
bell_ccx.ll to examples folder and dynamicbv.ll to test data folder
|
Hi @josephleekl -- we are working on the C-API implementation and enabled a single runtime interface, which should make passing runtime/quantum interfaces easier so that one can run an arbitrary number of shots. See #37 for diff. Kindly merge the 'main' branch in and update the qir-lightning app and tests accordingly! Thank you. |
Thanks for the heads up @wongey , I've now merged the main branch and updated our runtime/app similar to qsim. It should work now, do let me know if there are any issues! |
|
Hi @josephleekl -- thanks for pulling the main branch in! Can you activate the qir-lightning tests in the CI? Heads up that they are not currently passing locally. |
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
Working through this; there are some infrastructure/software engineering issues that to be addressed :)
|
Thanks @sethrj for your comments! I've now made some updates following your suggestions. |
|
I love that we're one black cat reviewing another 😹 |
sethrj
left a comment
sethrj
left a comment
There was a problem hiding this comment.
This looks really good! Thanks for adding the capability and waiting so long for my reviews 😅
4 participants
This PR enables QIR-EE to use any Pennylane Lightning simulator backend (more info here).
Instruction for building the main app is included in
src/qirlightning/README.md. A simple demo is also included withinsrc/qirlightning/simple_demo.Please feel free to play with it and ask any questions, happy to answer them!