-
Notifications
You must be signed in to change notification settings - Fork 16
[DAPS-1659] remove dependencies install scripts #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshuaSBrown
wants to merge
20
commits into
devel
Choose a base branch
from
1659-remove-dependencies-install-scripts
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−1,595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors all dependency installation scripts to use the new external/DataFedDependencies submodule by updating script paths in docs, CI/CD configs, and shell scripts, and removes the now-redundant local install scripts. Flow diagram for updated dependency installation processflowchart TD
A["Start installation"] --> B["Call install script in external/DataFedDependencies/scripts"]
B --> C["Dependency installed"]
C --> D["Repeat for each required dependency"]
D --> E["Installation complete"]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…f requirements.txt to DataFedDependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Removing all redundant scripts, now that all dependencies are in submodule.
How Has This Been Tested?
Artifacts (if appropriate):
Tasks
Summary by Sourcery
Centralize and consolidate dependency installation by migrating scripts into the DataFedDependencies submodule, updating references across code, CI, and docs, and removing obsolete local scripts
Enhancements:
CI:
Documentation:
Chores: