Skip to content

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Sep 25, 2025

Ticket

Description

Removing all redundant scripts, now that all dependencies are in submodule.

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

Summary by Sourcery

Centralize and consolidate dependency installation by migrating scripts into the DataFedDependencies submodule, updating references across code, CI, and docs, and removing obsolete local scripts

Enhancements:

  • Point all dependency installation script references to the DataFedDependencies submodule
  • Update shell scripts to source versions and functions from the submodule

CI:

  • Adjust GitLab and GitHub workflows to invoke installation scripts from the submodule

Documentation:

  • Revise administration documentation to use new submodule script paths

Chores:

  • Remove redundant local dependency install and utility scripts

Copy link
Contributor

sourcery-ai bot commented Sep 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors all dependency installation scripts to use the new external/DataFedDependencies submodule by updating script paths in docs, CI/CD configs, and shell scripts, and removes the now-redundant local install scripts.

Flow diagram for updated dependency installation process

flowchart TD
    A["Start installation"] --> B["Call install script in external/DataFedDependencies/scripts"]
    B --> C["Dependency installed"]
    C --> D["Repeat for each required dependency"]
    D --> E["Installation complete"]
Loading

File-Level Changes

Change Details Files
Update script invocations and sources to reference external/DataFedDependencies submodule
  • Repoint install_* script calls in documentation and CI pipelines to external/DataFedDependencies
  • Update source statements for dependency_versions.sh, dependency_install_functions.sh, and utils.sh
  • Adjust paths in GitLab and GitHub workflow YAML files for dependency installation steps
docs/admin/general.html
.gitlab/stage_provision_client.yml
scripts/install_foxx.sh
scripts/install_ws.sh
.github/workflows/build-docs.yml
.github/workflows/unit-tests.yml
scripts/compose_build_images.sh
scripts/compose_cleanup_globus_files.sh
scripts/compose_generate_globus_files.sh
scripts/export_dependency_version.sh
scripts/install_lego_and_certificates.sh
Remove redundant local dependency installation and utility scripts
  • Delete all install_* scripts that are now provided by the submodule
  • Delete dependency_install_functions.sh and utils.sh from the root scripts directory
scripts/dependency_install_functions.sh
scripts/install_authz_dependencies.sh
scripts/install_client_dependencies.sh
scripts/install_core_dependencies.sh
scripts/install_dependencies.sh
scripts/install_docker_dependencies.sh
scripts/install_docs_dependencies.sh
scripts/install_end_to_end_test_dependencies.sh
scripts/install_gcs.sh
scripts/install_python_client_dependencies.sh
scripts/install_repo_dependencies.sh
scripts/install_ws_dependencies.sh
scripts/utils.sh
Adjust documentation to new submodule paths
  • Update HTML example commands to use external/DataFedDependencies directory
docs/admin/general.html

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@JoshuaSBrown JoshuaSBrown self-assigned this Sep 29, 2025
@JoshuaSBrown JoshuaSBrown added the Priority: Medium Above average priority label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Above average priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant