Skip to content

Update to SUNDIALS 7.4.0 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update to SUNDIALS 7.4.0 #160

wants to merge 1 commit into from
+2 −2

Conversation

Steven-Roberts
Copy link
Collaborator

Description

Updates to latest version of SUNDIALS which includes a bug fix for IDA that was previously causing a seg fault in #105

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

superwhiskers
superwhiskers approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@superwhiskers superwhiskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've tested this on my machine with sundials 7.4.0. i'm unable to run the enzyme tests as it looks like i need to mess around with enzyme a little to get it to work right but all of the tests i am able to run pass without issue. this should be fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superwhiskers superwhiskers superwhiskers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steven-Roberts @superwhiskers