Skip to content

Conversation

@PhilipFackler
Copy link
Collaborator

@PhilipFackler PhilipFackler commented Oct 3, 2025

Description

  • Add direct output and exit without an exception
  • Make help message more helpful
  • Install target binaries in examples tree in the same place as the JSON files

Closes #252

This is intended to more appropriately implement the changes requested in #235.

Proposed changes

  • Help message explains you either provide the input file on the command line or run from the example directory
  • The bin install destination should be reserved for actual project executables. It makes more sense for example executables to live under share, and that's where I already had the JSON files being installed. This also follows the convention of the build tree.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/tiny-twobus-examples branch from 57c4660 to fc457a6 Compare October 3, 2025 20:33
@pelesh pelesh closed this Oct 7, 2025
@pelesh pelesh reopened this Oct 7, 2025
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests need to pass.

@nkoukpaizan, is the failing test perhaps due to #234?

@nkoukpaizan
Copy link
Collaborator

All tests need to pass.

@nkoukpaizan, is the failing test perhaps due to #234?

Yes, it is due to #234.

@PhilipFackler PhilipFackler requested a review from pelesh October 7, 2025 17:58
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pelesh pelesh merged commit 2601fe2 into develop Oct 8, 2025
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: TwoBusTgov1 throws exception

4 participants