-
Notifications
You must be signed in to change notification settings - Fork 158
Show files under hidden directories in job composer #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am having some trouble developing the myjobs app, so these changes are not tested at the moment. It does seem to be passing all of the automated testing, but not sure how extensive this is for the myjobs app. |
|
Were you able to boot up the job composer to test these changes? |
|
I was able to boot the job composer, but this seems like a difficult problem to test. Even if we put the scripts for the job in a hidden folder, myjobs moves them to a designated project folder that will never be hidden. The original discourse worked out of .ondemand as the root folder, and so set the OOD_DATAROOT variable to |
|
Setting OOD_DATAROOT in |
|
Tested this out and it works. I think we're good, though I think I'd like to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Works well for me.
Fixes #2268 by rejecting only hidden files, not files under hidden directories. Modifies and expands testing of this method