Skip to content

Conversation

@Bubballoo3
Copy link
Contributor

Fixes #2268 by rejecting only hidden files, not files under hidden directories. Modifies and expands testing of this method

@Bubballoo3 Bubballoo3 changed the title change under_dotfile? to is_dotfile? Show files under hidden directories in job composer Aug 18, 2025
@Bubballoo3
Copy link
Contributor Author

I am having some trouble developing the myjobs app, so these changes are not tested at the moment. It does seem to be passing all of the automated testing, but not sure how extensive this is for the myjobs app.

@Bubballoo3 Bubballoo3 added the status/awaiting review Changes made by dev, waiting for reviewers label Sep 3, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Review in PR Review Pipeline Sep 8, 2025
@johrstrom
Copy link
Contributor

Were you able to boot up the job composer to test these changes?

@Bubballoo3
Copy link
Contributor Author

Bubballoo3 commented Sep 15, 2025

I was able to boot the job composer, but this seems like a difficult problem to test. Even if we put the scripts for the job in a hidden folder, myjobs moves them to a designated project folder that will never be hidden. The original discourse worked out of .ondemand as the root folder, and so set the OOD_DATAROOT variable to #{HOME}/.ondemand/.../.../myjobs. I can't seem to get the OOD_DATAROOT variable to change (tried .env.local and .env.override) and when I try in the dev container I can't get the job composer working. I also suspect it would be a good deal of work to configure the dev container to read out of a .ondemand folder. Any suggestions?

@johrstrom
Copy link
Contributor

Setting OOD_DATAROOT in .env.local should work, though you'd need to bounce your PUN for it to get picked up. I can take a look at this a bit more later this week.

@johrstrom
Copy link
Contributor

Tested this out and it works. I think we're good, though I think I'd like to use @path.basename just for simplicity over split('/')[-1].

@johrstrom johrstrom self-requested a review October 7, 2025 19:17
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works well for me.

@johrstrom johrstrom merged commit 44bdfa0 into master Oct 7, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Review to Merged/Closed in PR Review Pipeline Oct 7, 2025
@johrstrom johrstrom deleted the show-hidden-job-directories-2268 branch October 7, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/jobcomposer status/awaiting review Changes made by dev, waiting for reviewers

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

hidden job directories don't seem to work

4 participants