Shell app: log via ws.logger and add username, hostname and pty-term … #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PID in front - When logging inside the Shell app, include the username, the target host and the pty-term PID number in each message, to see which connection is causing the message. Prior to this, it was impossible to see which terminal connected to which host (since there could be multiple simultaneous terminals), and which terminal was causing potential error messages.
johrstrom
reviewed
Sep 24, 2025
apps/shell/app.js
Outdated
Comment on lines
191
to
193
| setpid: (newpid) => { | ||
| msgPrefix = `[User = ${username}; Host = ${host}; PID = ${newpid}]`; | ||
| }, |
There was a problem hiding this comment.
Is there any way to do this in a more functional style so we don't have msgPrefix as a variable?
There was a problem hiding this comment.
The challenge is that the PID isn't known when the logger is initialized. The PID will be known once the code gets to this line:
term = pty.spawn(cmd, args, {
//...There was a problem hiding this comment.
One solution is to log the Web socket connection established from user message with a normal console.log(), and initialize the ws.logger once the pty-term PID is known. I'll push an update.
- Do not initialize the ws.logger until the pty-term PID is known. - Add a few comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PID in front
Fixes #4626