-
Notifications
You must be signed in to change notification settings - Fork 163
Toggle group ownership on projects #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
7062548
9bca1b2
934a2fc
0d2b0fe
5a31c92
28fa47f
463fc20
62aa0b8
c1ab282
deed11a
99eee99
b081b2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,7 +111,7 @@ def importable_directories | |
| end | ||
| end | ||
|
|
||
| attr_reader :id, :name, :description, :icon, :directory, :template, :files | ||
| attr_reader :id, :name, :description, :icon, :directory, :template, :files, :group_owner | ||
|
|
||
| validates :name, presence: { message: :required }, on: [:create, :update] | ||
| validates :id, :directory, :icon, presence: { message: :required }, on: [:update] | ||
|
|
@@ -128,6 +128,7 @@ def initialize(attributes = {}) | |
| @directory = attributes[:directory] | ||
| @directory = File.expand_path(@directory) unless @directory.blank? | ||
| @template = attributes[:template] | ||
| @group_owner = attributes[:group_owner] || get_group_owner | ||
|
|
||
| return if new_record? | ||
|
|
||
|
|
@@ -203,6 +204,29 @@ def remove_from_lookup | |
| false | ||
| end | ||
|
|
||
| def private? | ||
| project_dataroot.to_s.start_with?(CurrentUser.home) | ||
| end | ||
|
|
||
| def get_group_owner | ||
| if project_dataroot != Project.dataroot && project_dataroot.grpowned? | ||
| Etc.getgrgid(project_dataroot.stat.gid).name | ||
| else | ||
| nil | ||
| end | ||
| end | ||
|
|
||
| def set_group_owner | ||
| return true if private? || @group_owner == get_group_owner | ||
|
||
| begin | ||
| group_gid = @group_owner.nil? ? nil : Etc.getgrnam(@group_owner).gid | ||
| FileUtils.chown(nil, group_gid, project_dataroot) | ||
| rescue StandardError => e | ||
| errors.add(:update, "Unable to set group ownership with error #{e.class}:#{e.message}") | ||
| false | ||
| end | ||
| end | ||
|
|
||
| def editable? | ||
| File.writable?(manifest_path) | ||
| end | ||
|
|
@@ -305,6 +329,7 @@ def update_attrs(attributes) | |
|
|
||
| def make_dir | ||
| project_dataroot.mkpath unless project_dataroot.exist? | ||
| set_group_owner | ||
|
||
| configuration_directory.mkpath unless configuration_directory.exist? | ||
| workflow_directory = Workflow.workflow_dir(project_dataroot) | ||
| workflow_directory.mkpath unless workflow_directory.exist? | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.