Skip to content

Conversation

@Bubballoo3
Copy link
Contributor

Fixes #4778. While the validation in #4779 prevents repetition of the original error, it seems prudent to redirect the index pages just in case something else causes a redirect like this. This is completely safe since the index routes are currently unused, and we redirect them to the Project show page, which is an effective index of both launchers and workflows.

In summary, this is a precautionary measure to rescue a currently fatal error of being redirected to a non-existent index page

@johrstrom
Copy link
Contributor

Seems simple enough, but I guess I'll have to pull it down and replicate the issue to get an understanding of the issue and why this would solve it. Seems like just adding routes (that are unused) wouldn't solve anything, so I'm going to have to dig in a bit more.

@Bubballoo3
Copy link
Contributor Author

Bubballoo3 commented Dec 4, 2025

Yeah I wish I had documented how I encountered this error in the original ticket. I think the best explanation is that the index actions launchers and workflows are already being defined by resources: workflows. So I ran into some rails default that kicked me from a new_workflow route to workflows, which exists as a route but doesn't have an associated view, giving me the error.

As I mention above I am pretty sure this happened as I was working on #4779, so you might want to check out the version before that if you want to replicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

fix redirects when handling broken submissions

4 participants