Skip to content

Fixing PUN management of config home #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djareval wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing PUN management of config home #5167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packaging/rpm/ondemand-selinux.fc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@
/opt/ood/apps/[^/]+/public(/.*)? gen_context(system_u:object_r:ood_apps_public_t,s0)
/var/www/ood/apps/sys/[^/]+/bin/.+ gen_context(system_u:object_r:ood_pun_exec_t,s0)
/opt/ood/apps/[^/]+/bin/.+ gen_context(system_u:object_r:ood_pun_exec_t,s0)
HOME_DIR/\.config/ondemand(/.*)? gen_context(system_u:object_r:ood_pun_config_t,s0)
Copy link
Copy Markdown
Contributor

@treydock treydock Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this would require something to either run restorecon if already exists or the new directory would inherit this context.

However this doesn't work on NFS.

$ sudo chcon -R -t config_home_t /users/sysp/tdockendorf/.config/ondemand
chcon: failed to change context of 'settings.yml' to ‘system_u:object_r:config_home_t:s0’: Operation not supported
chcon: failed to change context of '/users/sysp/tdockendorf/.config/ondemand' to ‘system_u:object_r:config_home_t:s0’: Operation not supported

This change will cause issues for people using NFS home directories which is one of the more common usages with OnDemand.

Copy link
Copy Markdown
Author

@djareval djareval Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this would require running restorecon.

That chcon failure may be due to using NFSv4.0, which doesn't support the security xattrs required for SELinux contexts. We use NFSv4.2 for home and have no issue running chcon:

$ restorecon -FRv ~/.config/ondemand
$ chcon -R -t user_tmp_t ~/.config/ondemand
$ restorecon -FRv ~/.config/ondemand
Relabeled /mnt/home/djareval/.config/ondemand from staff_u:object_r:user_tmp_t:s0 to staff_u:object_r:config_home_t:s0
Relabeled /mnt/home/djareval/.config/ondemand/settings.yml from staff_u:object_r:user_tmp_t:s0 to staff_u:object_r:config_home_t:s0

But this proposed change shouldn't negatively impact a setup like yours. For instance, the SELinux policy on your system probably lists default contexts other than nfs_t for your home files. Here's our on RHEL 9.7:

$ matchpathcon ~
/home/djareval   staff_u:object_r:user_home_dir_t:s0

$ matchpathcon ~/.config/ondemand
/home/djareval/.config/ondemand  staff_u:object_r:config_home_t:s0

But running restorecon on the home directories just has no effect? Or does it also generate errors?

22 changes: 7 additions & 15 deletions packaging/rpm/ondemand-selinux.te
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,13 @@ read_lnk_files_pattern(ood_pun_t, ood_apps_public_t, ood_apps_public_t)
read_files_pattern(httpd_t, ood_apps_public_t, ood_apps_public_t)
read_lnk_files_pattern(httpd_t, ood_apps_public_t, ood_apps_public_t)

## <desc>
## <p>
## Allow OnDemand to manage user .config directories labelled with config_home_t
## </p>
## </desc>
gen_tunable(ondemand_manage_config_dir, false)
Copy link
Copy Markdown
Contributor

@treydock treydock Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of the tunable is the wrong approach. The context trying to be forced here does not apply to everyone so should not be forced on everyone.

Copy link
Copy Markdown
Author

@djareval djareval Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @treydock.
I would argue that the context does apply to every setup that is capable of utilizing SELinux context labels. In your case, NFSv4.0 doesn't support the security xattrs required for SELinux contexts, so it's not actually using them, just bypassing with a blanket nfs_t.

But I wouldn't think that's an issue; there are other default SELinux context labels that your NFSv4.0 isn't utilizing (user_home_dir_t and user_home_t) but that doesn't cause any problems, does it?

Copy link
Copy Markdown
Contributor

@treydock treydock Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% certain how this will work on NFS v4.0 and easiest way to test will be to verify at OSC with our nightly builds once merged. We run SELinux only on our dev nightly hosts and only in permissive mode.

tunable_policy(`ondemand_manage_config_dir',`
ifdef(`config_home_t',`
type ood_pun_config_t;
allow ood_pun_t config_home_t:dir { add_name write create };
manage_files_pattern(ood_pun_t, ood_pun_config_t, ood_pun_config_t)
manage_dirs_pattern(ood_pun_t, ood_pun_config_t, ood_pun_config_t)
filetrans_pattern(ood_pun_t, config_home_t, ood_pun_config_t, dir, "ondemand")
')
')
# user-specific config files
type ood_pun_config_t;
files_type(ood_pun_config_t)
gnome_config_filetrans(ood_pun_t, ood_pun_config_t, dir, "ondemand")
gnome_create_home_config_dirs(ood_pun_t)
Comment on lines +105 to +106
Copy link
Copy Markdown
Contributor

@treydock treydock Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this using gnome_config_filetrans and not filetrans_pattern?

Copy link
Copy Markdown
Author

@djareval djareval Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practicing encapsulation. Using filetrans_pattern would require referencing config_home_t directly, thus adding another line to the require block. Ideally the only type labels in the file would be ood*_t. Any interaction with extenral types should happen through interface calls and gnome_config_filetrans seems to fit the bill exactly for the needed transition.

manage_files_pattern(ood_pun_t, ood_pun_config_t, ood_pun_config_t)
manage_dirs_pattern(ood_pun_t, ood_pun_config_t, ood_pun_config_t)

## <desc>
## <p>
Expand Down
Loading