Emit change event on data-set (fixes #5234)#5235
Open
epruesse wants to merge 1 commit intoOSC:masterfrom
Open
Conversation
Contributor
|
This does not appear to pass unit tests preserving behavior. I'd have to look into it more thoroughly to see if we have to preserve behavior (generally I'd like to) or if it's in fact a behavior we should/need to change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5234 I believe (untested)
I also got rid of
setCheckboxValueand moved ariaStream message to be called only if the value really did change.