Fix hardcoded string composition with internationalizations (#5293)#5312
Open
bstepanovski wants to merge 5 commits intomasterfrom
Open
Fix hardcoded string composition with internationalizations (#5293)#5312bstepanovski wants to merge 5 commits intomasterfrom
bstepanovski wants to merge 5 commits intomasterfrom
Conversation
johrstrom
reviewed
Apr 13, 2026
Comment on lines
+10
to
+15
| before(:all) do | ||
| upload_portal_config('portal.yml') | ||
| update_ood_portal | ||
| restart_apache | ||
| restart_dex | ||
| end |
Contributor
There was a problem hiding this comment.
I'm hesitant to add this. Seems like it could cause more flakiness to be bouncing things all the time.
Bubballoo3
requested changes
Apr 24, 2026
Contributor
Bubballoo3
left a comment
Bubballoo3
left a comment
There was a problem hiding this comment.
It seems like the only open question is the modifications to the E2E tests, so you should just split that out into a separate change so we can properly discuss them
github-project-automation
Bot
moved this from Awaiting Review
to Changes Requested
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5293