Fix rerendering on invalid form.yml.erb files#5319
Open
andrejcermak wants to merge 3 commits intoOSC:masterfrom
Open
Fix rerendering on invalid form.yml.erb files#5319andrejcermak wants to merge 3 commits intoOSC:masterfrom
andrejcermak wants to merge 3 commits intoOSC:masterfrom
Conversation
Contributor
Author
|
Even though this is an individual PR, it could also be seen as part of the caching initiative as it caches invalid apps and doesn't allow re-rendering. |
Contributor
|
The other PR you have open may be eaiser to merge because it's simpler. This, I'm not so sure about. It'll require some thought, which we don't have a lot to spare given we're trying to merge all our accessibility issues and urgently release 4.2 for the same. |
Contributor
Author
|
@johrstrom thats fine by me, I think the other PR was much more important. This is more of a failsafe mechanism and is not urgent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5057.
Fix memoisation & UI filtering for malformed Batch Connect apps
defined?(@form_config)so an empty hash is cached and the ERB is not reparsed on every call.valid?to avoid repeated form_config look‑ups.valid_batch_connect_app?validity check