Skip to content

Add collapsible Batch Connect app sidebar menus #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliketocode2 wants to merge 4 commits into
base: master
Choose a base branch
from
+64 −3
Open

Add collapsible Batch Connect app sidebar menus #5321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ff14af
Move final code for collapsible sidebar into final branch
Apr 13, 2026
3e807ce
Contributing compliance and testing
Apr 13, 2026
1544691
Bootstrap implementation
Apr 14, 2026
2608c79
Start expanded, simplify css
Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/dashboard/app/assets/stylesheets/batch_connect/sessions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,28 @@
background-color: #f5f5f5;
}

.collapsible-app-card {
.collapsible-app-card-toggle {
cursor: pointer;
display: flex;
align-items: center;
justify-content: space-between;

&::after {
content: "";
width: 0;
height: 0;
border-style: solid;
border-width: 0.3rem 0 0.3rem 0.45rem;
border-color: transparent transparent transparent currentColor;
}

&[aria-expanded="true"]::after {
transform: rotate(90deg);
}
}
}

.custom-range {
height: 4px;
box-shadow: inset 0 1px 10px gray;
Expand Down
21 changes: 18 additions & 3 deletions apps/dashboard/app/views/batch_connect/shared/_app_list.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
<div class="card <%= local_assigns.fetch(:style, "system-and-shared-apps-header") %>">
<div class="card-header"><%= title %></div>
<div class="list-group list-group-flush">
<%
# HTML ids use underscores per project convention (see CONTRIBUTING.md).
# Parameterize the card title so ids stay valid and pair with aria-controls.
slug = title.to_s.parameterize(separator: "_").presence || "group"
list_dom_id = "bc_app_list_#{slug}_items"
%>
<div class="card collapsible-app-card <%= local_assigns.fetch(:style, "system-and-shared-apps-header") %>">
<button
class="card-header collapsible-app-card-toggle"
type="button"
data-bs-toggle="collapse"
data-bs-target="#<%= list_dom_id %>"
aria-expanded="true"
aria-controls="<%= list_dom_id %>"
>
<span><%= title %></span>
</button>
<div id="<%= list_dom_id %>" class="list-group list-group-flush collapse show">
<%-
OodAppGroup.groups_for(
apps: apps,
Expand Down
24 changes: 24 additions & 0 deletions apps/dashboard/test/system/batch_connect_sessions_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,30 @@ def stub_scheduler(state, cores: 1, nodes: 1)
assert_equal(I18n.t('dashboard.batch_connect_no_sessions'), no_session_text)
end

test 'collapsible batch connect app menu toggles' do
visit(batch_connect_sessions_path)

within('nav[aria-label="Interactive Apps Menu"]') do
card = find('.collapsible-app-card', match: :first)
button = card.find('button.collapsible-app-card-toggle')
target_id = button['aria-controls']
list_group = card.find("##{target_id}", visible: :all)

assert_equal('false', button['aria-expanded'])
assert_not_includes(list_group[:class], 'show')

button.click

assert_selector("##{target_id}.show")
assert_equal('true', button['aria-expanded'])

button.click

assert_no_selector("##{target_id}.show")
assert_equal('false', button['aria-expanded'])
end
end

test 'queued session' do
Dir.mktmpdir do |dir|
create_test_file(dir)
Expand Down