Added more dashboard localizations (#1960)#5357
Conversation
expose global datatables language config from Rails i18n and apply it in application JS so the table is auto-initialized with the correct locale configs. Also localized remaining hard coded strings in this page.
Replaced hard coded strings with I18n and added corresponding string entries in en.yml file
replaced some hard coded strings with i18n for some files under bc_desktop/session_context/new
Expose XDMoD i18n JSON to the frontend and replace hard-coded English strings in the XDMoD widgets
Displayed sys files on the dashboard page and added more chinese translations
There was a problem hiding this comment.
Please do not modify javascript files for localization - we haven't built any foundational stuff for that yet.
There was a problem hiding this comment.
Same comment above regarding javascript files.
| data-current-filesystem="<%= @filesystem %>" | ||
| data-download-error-title="<%= t('dashboard.files_directory_download_error_modal_title') %>" | ||
| data-current-files-upload-path="<%= url_for(fs: @filesystem, action: 'upload') if Configuration.upload_enabled? %>" | ||
| data-label-filter="<%= t('dashboard.files_filter') %>" |
There was a problem hiding this comment.
We have #5124 open to add internationalization to javascript, and I don't think we want to bulk up the config object so much until we have a unified strategy. At the very least we should split this up into server-side internationalizations in ruby (the easy part), and javascript changes in a separate PR where we can really dig in and find the most efficient approach.
| @@ -0,0 +1,4 @@ | |||
| pinned_apps: | |||
There was a problem hiding this comment.
Looks like this file was added by mistake
| # Using the sleep to wait before reload | ||
| sleep(2.0) | ||
| redirect_to active_jobs_path, :notice => "Successfully deleted #{job_id}" | ||
| redirect_to active_jobs_path, :notice => t('dashboard.active_jobs.delete_success', job_id: job_id, default: "Successfully deleted %{job_id}") |
There was a problem hiding this comment.
We have a configuration that will raise errors on missing internationalizations, so providing a default value is always going to be unnecessary
4 participants
Added missing i18n keys for texts on /dashboard, /files, /activejobs, /projects, /module-browser, and /system-status pages.