Open
Conversation
Replace hard coded english labels with i18n keys for buttons like refresh, new files, new directory, copy/move, and delete Add English and zh-CN strings
johrstrom
reviewed
Apr 24, 2026
| <th><span class="sr-only">Type</span></th> | ||
| <th>Name</th> | ||
| <th><span class="sr-only">Actions</span></th> | ||
| <th><span class="sr-only"><%= t('dashboard.files_turboframe.type') %></span></th> |
Contributor
There was a problem hiding this comment.
Simple/single works like Type should be just simple/single word keys like dashboard.type. That promotes reuse and also simplicity.
johrstrom
reviewed
Apr 24, 2026
Contributor
There was a problem hiding this comment.
I think you added this file by accident. Furthermore, if this is a development config - you should be using a directory outside of the git tree. Mostly for this exact reason - so you don't accidentally commit it.
* localize active_jobs/index.html.erb * localize active_jobs/_job_details_node_view.html.erb * localize active_jobs/extended_data_table.html.erb --------- Co-authored-by: Braeden Singleton <bsingleton@osc.edu>
Bubballoo3
reviewed
May 6, 2026
| <%= link_to image_tag( build_ganglia_link(data.cluster, data.starttime, 'load_report', node, 'small'), class:"img-responsive col-lg-auto col-md-auto col-sm-auto col-xs-auto", alt: "Ganglia image for system load averages." ), build_ganglia_link(data.cluster, data.starttime, 'load_report', node, 'large'), data: { lightbox: "load-report", title: "Load Report " + node } %> | ||
| <%= link_to image_tag( build_ganglia_link(data.cluster, data.starttime, 'mem_report', node, 'small'), class:"img-responsive col-lg-auto col-md-auto col-sm-auto col-xs-auto", alt: "Ganglia image for Memory usage." ), build_ganglia_link(data.cluster, data.starttime, 'mem_report', node, 'large'), data: { lightbox: "mem-report", title: "Memory Report " + node } %> | ||
| <%= link_to image_tag( build_ganglia_link(data.cluster, data.starttime, 'network_report', node, 'small'), class:"img-responsive col-lg-auto col-md-auto col-sm-auto col-xs-auto", alt: "Ganglia image for network usage." ), build_ganglia_link(data.cluster, data.starttime, 'network_report', node, 'large'), data: { lightbox: "network-report", title: "Network Report " + node } %> | ||
| <%= link_to image_tag( build_ganglia_link(data.cluster, data.starttime, 'cpu_report', node, 'small'), class:"img-responsive col-lg-auto col-md-auto col-sm-auto col-xs-auto", alt: t('dashboard.active_jobs_ganglia_alt_cpu')), build_ganglia_link(data.cluster, data.starttime, 'cpu_report', node, 'large'), data: { lightbox: "cpu-report", title: "#{t('dashboard.cpu_report')} #{node}" } %> |
Contributor
There was a problem hiding this comment.
Let's pass the node info to the localization in case the order changes for other languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced hard coded English texts with i18n keys in app/views/files files used for /dashboard/files path.