Localization batch_connect/session_contexts#5437
Closed
SimonX1a0 wants to merge 8 commits intolocalization-1960from
Closed
Localization batch_connect/session_contexts#5437SimonX1a0 wants to merge 8 commits intolocalization-1960from
SimonX1a0 wants to merge 8 commits intolocalization-1960from
Conversation
Contributor
|
I think you may want to clean up the commit history on here, it looks like several commits (or at least the content) is duplicated in #5359. You should try to edit each file in a single PR, otherwise we will just have a bunch of merge conflicts after one of these go through. The title here looks like it should be more limited in scope, so maybe this is just a git mixup? |
Author
|
Looks like there a git mixup when I created the new branch from a merged branch. I'll go ahead and clean this up. |
github-project-automation
Bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.