Increase Rakefile compatibility #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Aug 4, 2025
Rakefile
Outdated
Comment on lines
57
to
58
| user_section = '' | ||
| current_dir = '.' | ||
| if !windows? | ||
| user_section = "-u '#{user_group}'" | ||
| end | ||
| "docker run --rm -it -v \"#{__dir__}:/doc\" #{user_section} #{image}" |
There was a problem hiding this comment.
current_dir doesn't appear to be used.
Can you turn user_selection into a ternary like
user_selection = windows? : nil ? "-u '#{user_group}'"
Also does single quote `'` not work here? `\"` always looks funny to me.There was a problem hiding this comment.
Thanks for catching that, I removed the current_dir variable and included the ternary in place of the if statement. The double quotes are necessary as the single quotes (when passed through by exec()) are interpreted as a volume name by docker (on windows). We could use no quotes instead, but double quotes will keep the same protection against spaces in the path.
Bubballoo3
force-pushed
the
cross-platform
branch
from
0c1b7a2 to
f9928fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for WSL to build docs, simplifying the process as described in OSC/ood-documentation-build#24. Tested on Ubuntu and Powershell, should retain old functionality across other UNIX systems and macs (but not tested)