CI(docker): Add docker labels from metadata #6667
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
It still looks like it is adding a new workflow. Can you review your PR, try it on your fork, and let us know when we should look at it again? |
Author
|
Thanks for pointing that out — I’ve reviewed the PR again and removed the stray workflow file. I tested this on my fork, and the workflow runs fine — but the |
echoix
reviewed
Nov 29, 2025
Member
echoix
left a comment
echoix
left a comment
There was a problem hiding this comment.
Im reading about how labels should be created by the action. In case I still can't be sure, I would be comfortable to merge and try to fix after
Comment on lines
+202
to
+203
|
|
||
|
|
echoix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6511.
Following the maintainer’s guidance, this updates the Docker workflow to use the outputs of docker/metadata-action not only for annotations but also for image labels.
The goal is to ensure the metadata generated by the action is fully utilized in the build-and-push step, aligning the workflow with the examples shown in the upstream docker metadata documentation.
If anything else should be added or adjusted, I’m happy to iterate further.