-
-
Notifications
You must be signed in to change notification settings - Fork 401
r.fillnulls: avoid locale-dependent stderr parsing #6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bfd66bd to
0881726
Compare
|
Please add a test for it. |
|
Thanks for the clarification @marisn , and apologies for missing the test initially |
|
Added a regression test (test_no_nulls) covering the no-NULL input case to ensure r.fillnulls exits successfully without relying on stderr parsing. CI is running. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| }, | ||
| precision=1e-6, | ||
| ) | ||
| def test_no_nulls(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ruff] reported by reviewdog 🐶
| def test_no_nulls(self): | |
| def test_no_nulls(self): |
This PR fixes a locale-dependent bug in r.fillnulls when using bilinear/bicubic interpolation.
Instead of parsing English error messages from r.resamp.bspline stderr, the script now checks for NULL cells using
r.univar -gand exits early when none are present.This avoids failures in non-English locales and simplifies the control flow.
Fixes #1495.