-
-
Notifications
You must be signed in to change notification settings - Fork 95
Snapshot Summary #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yashgupta9330
wants to merge
16
commits into
OWASP:main
Choose a base branch
from
Yashgupta9330:yash4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Snapshot Summary #1336
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
80cde4a
added
Yashgupta9330 b875e54
pulled
Yashgupta9330 9341c52
Merge branch 'main' into yash4
Yashgupta9330 54e119b
Merge branch 'OWASP:main' into yash4
Yashgupta9330 414dd1d
fixed
Yashgupta9330 dd2d13a
Merge branch 'main' into yash4
Yashgupta9330 de77bfa
added
Yashgupta9330 6267aec
pulled
Yashgupta9330 a5eba95
pulled
Yashgupta9330 eb190a2
fixed
Yashgupta9330 3965f77
fixed
Yashgupta9330 9be431d
fixed
Yashgupta9330 cc724e8
added
Yashgupta9330 d89aede
added
Yashgupta9330 1a74ef2
Merge branch 'main' into yash4
Yashgupta9330 260f39d
Merge branch 'main' into yash4
Yashgupta9330 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ export const GET_SNAPSHOT_DETAILS = gql` | |
key | ||
startAt | ||
title | ||
summary | ||
newReleases { | ||
name | ||
publishedAt | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Add unit tests for the new functionality.
The
generate_summary
method is a good candidate for unit testing to ensure it handles different data scenarios correctly.🏁 Script executed:
Length of output: 1868
Action Required: Add Dedicated Unit Tests for the
generate_summary
MethodWhile there are existing tests for the Snapshot model (as seen in
backend/tests/apps/owasp/models/snapshot_test.py
), it isn’t clear that the newgenerate_summary
functionality is specifically covered. Please add unit tests that ensure the method behaves correctly under various data conditions. For example:max_examples
) is enforced.