Avoid unnecessary copies #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesamuel
approved these changes
Feb 2, 2024
| @@ -846,15 +846,15 @@ Property forKey(String propertyName) { | |||
| builder.put("z-index", bottom); | |||
| builder.put("repeating-linear-gradient()", linearGradient$Fun); | |||
| builder.put("repeating-radial-gradient()", radialGradient$Fun); | |||
| DEFINITIONS = Map.copyOf(builder); | |||
| DEFINITIONS = Collections.unmodifiableMap(builder); | |||
There was a problem hiding this comment.
Ok. I see builder allocated locally at 263
There was a problem hiding this comment.
Exactly, I renamed all variables to include bulder to make it more clear.
Signed-off-by: Sven Strickroth <[email protected]>
csware
force-pushed
the
guava-migration-do-less
branch
from
cea5a2c to
87d63f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These copies were introduced with PR #272.
This related to #301 and works with Java 9.