updated the draft crypto principles to match today's cryptographic standards, and fixed grammatical issues #348
+20
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadsden
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks for the update @pUrGe12 , could you refer to the contributing guide to fix the tests
| @@ -182,7 +184,7 @@ which is only used for the duration of the encrypted communication. | |||
| This random session key is then encrypted using an asymmetric cipher and the recipient's private key. | |||
| The plaintext data itself is encrypted with the session key. | |||
| Then the entire bundle (encrypted session key and encrypted message) is all sent together. | |||
| Both [TLS][tls] and S/MIME are common cryptosystems using hybrid cryptography. | |||
| Both [TLS 1.3][tls] and S/MIME are common cryptosystems using hybrid cryptography today. | |||
There was a problem hiding this comment.
we should not provide a version for TLS here, this may go out of date so it is better to not version it
There was a problem hiding this comment.
ahh yes, I'll edit this properly. My bad, I'll fix my tests.
…character in the end, in accordance with the lint markdown test
|
okay I see the issue, lemme try again with a new PR. (ps, sorry about doing this again and again, I'm trying to get this right) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
This is a fix for issue #346 which called for a revision of principles of cryptography section to match today's standards. The major changes have been listen in the next section.
Following the discussion on #347 I have added the changes in the draft and reverted the changes in the release file.
Description for the changelog :
I have made the following major changes.
Stream cipher examples, RC4 to ChaCha20 (because the RC4 algorithm has many vulnerabilities like biases in the key scheduling algorithm)
Updated with TLS version 1.3 being the recommended one
Updated with note on DES not being a standard, and added AEAD schemes.
Corrected spelling errors and other grammatical issues
Added link to the cryptographic storage cheat sheet.
Other info :