Skip to content

Conversation

@Padraic-O-Mhuiris
Copy link
Collaborator

No description provided.

@Padraic-O-Mhuiris Padraic-O-Mhuiris changed the base branch from main to readme-updates November 24, 2025 17:55
@Padraic-O-Mhuiris Padraic-O-Mhuiris changed the base branch from readme-updates to doc-improvements November 24, 2025 17:55
@Padraic-O-Mhuiris Padraic-O-Mhuiris changed the base branch from doc-improvements to main November 25, 2025 01:18
@bussyjd
Copy link
Collaborator

bussyjd commented Nov 25, 2025

  • EnvVar struct naming is a bit confusing..maybe TemplateField

  • Either enforce single-word network names or always require the slash separator and make the network name parsing a helper (used twice).

  • extractTemplateFields() needs to return deterministic sorting

  • We don't have network list --installed or similar?

  • Missing Validation on Template Execution - If a user provides a malformed value that breaks YAML syntax, the error occurs later during helmfile sync rather than at install time:

  if err := tmpl.Execute(&buf, templateData); err != nil {
      return fmt.Errorf("failed to execute values template: %w", err)
  }
  // No YAML validation of buf.Bytes() before writing
  • In values.yaml.gotmpl:
  @default Annotation Ambiguity - In values.yaml.gotmpl:

  # @default
  # @description Deployment identifier...
  id: {{.Id}}

The @default annotation with no value means "has a default" but the actual default comes from petname generation in Go code.

  • Needs user confirmation for network confirmation:
    eg: "Are you sure you want to delete ethereum-prod?"

  • Do we want to keep the helmfile.yaml.gotmpl in the deployment directory after install?

@Padraic-O-Mhuiris Padraic-O-Mhuiris merged commit c07ea71 into main Dec 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants