Feat/ddo v5 #58
Closed
Feat/ddo v5 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 18, 2024 11:55
This reverts commit ec4acf6.
AdriGeorge
reviewed
Feb 14, 2025
| @@ -1,2 +1,2 @@ | |||
| # Set | |||
| node ./scripts/load-development-addresses.js | |||
| node ./scripts/load-development-addresses.cjs | |||
AdriGeorge
reviewed
Feb 14, 2025
| if (accountId !== ZERO_ADDRESS) { | ||
| toast.error( | ||
| `Consumer address not found in allow list for service ${asset.id}. Access has been denied.` | ||
| `Consumer address not found in allow list for service ${asset.credentialSubject?.id}. Access has been denied.` |
AdriGeorge
reviewed
Feb 14, 2025
| <div> | ||
| <AssetTitle title={metadata.name} asset={row} /> | ||
| <p>{row.id}</p> | ||
| <p>{row.credentialSubject?.id}</p> |
AdriGeorge
reviewed
Feb 14, 2025
| <AssetTeaser | ||
| asset={asset} | ||
| key={asset.id} | ||
| key={asset.credentialSubject?.id} |
AdriGeorge
reviewed
Feb 14, 2025
| async function getDatasetsAllowedForCompute() { | ||
| const datasets = await getAlgorithmDatasetsForCompute( | ||
| asset.id, | ||
| asset.credentialSubject?.id, |
AdriGeorge
reviewed
Feb 14, 2025
| const credential: VCDataModel.Credential = { | ||
| ...asset, | ||
| type: ['VerifiableCredential'], | ||
| issuer: `${await owner.getAddress()}` |
There was a problem hiding this comment.
issuer is not everytime the address of web3account.. if ssi is on the issuer id issuerDid, check in cli
|
@FilipMasar can you please have a look into this pr? |
Author
|
This branch is depreacted. Every changes will be doing in the feat/ssiSupport branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new DDO v5 format to the market