Skip to content

Re-sync dotnet-install.ps1 to remove azureedge.net #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rhysparry
Copy link
Contributor

Background

The azureedge.net domain is no longer used to provide the .NET SDK. This PR synchronises our forked version of the dotnet-install.ps1 script with the upstream version.

Results

  • References to azureedge.net have been removed
  • The NoCdn parameter of the script has been removed (as per upstream)

How to review this PR

This PR primarily changes the old references to domains that are no longer used to serve the dotnet SDK. This keeps the changes relatively constrained following the most recent synchronisation:

To compare with the current version upstream, the following command can be run (tested in bash):

diff --color=auto --strip-trailing-cr <(curl --location https://dot.net/v1/dotnet-install.ps1) dotnet-install.ps1

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry requested a review from a team as a code owner January 16, 2025 02:40
@david-staniec-octopus
Copy link
Contributor

@@ -133,7 +129,6 @@ param(
[switch]$ProxyUseDefaultCredentials,
[string[]]$ProxyBypassList = @(),
[switch]$SkipNonVersionedFiles,
[switch]$NoCdn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, we're removing this as an option as the feeds this would direct you to are being decommissioned. I don't see this change upstream yet as mentioned in the PR description. Are we assuming this is pending an update upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made upstream:

The change should be present in https://dot.net/v1/dotnet-install.ps1

The process used for updating the file was:

  • Re-download the script
  • Using a diff tool, apply the relevant changes we need (TLS 1.2 enablement, signature removal)

@rhysparry rhysparry force-pushed the sast/sc-101376/remove-azureedge-net branch from 5819f4f to d691416 Compare February 13, 2025 22:58
@rhysparry rhysparry merged commit 4434cd3 into main Feb 13, 2025
16 checks passed
@rhysparry rhysparry deleted the sast/sc-101376/remove-azureedge-net branch February 13, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants