Skip to content

Conversation

rhysparry
Copy link
Contributor

@rhysparry rhysparry commented Sep 8, 2025

Background

We want to be able to track the TLS protocol versions used in secure connections. This pull request adds an ISecureConnectionObserver which can be used to determine the protocol used for incoming and outgoing secure TCP connections.

Results

When secure connections are established (and authorized), a call will be made to the observer providing key details of the connection:

  • Whether the connection is incoming or outgoing
  • The thumbprint associated with the connection
  • The TLS protocol used by the connection

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@rhysparry rhysparry force-pushed the rhys/secure-connection-observer branch from 9373ae1 to dc8d63f Compare September 12, 2025 02:57
@rhysparry rhysparry marked this pull request as ready for review September 12, 2025 04:35
@rhysparry rhysparry requested a review from a team as a code owner September 12, 2025 04:35
@rhysparry rhysparry force-pushed the rhys/secure-connection-observer branch from dc8d63f to b6258f2 Compare September 12, 2025 04:35
@LukeButters
Copy link
Contributor

Consider adding a test.

@rhysparry rhysparry merged commit e34a00a into main Sep 14, 2025
18 checks passed
@rhysparry rhysparry deleted the rhys/secure-connection-observer branch September 14, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants