Fixes a bug in the PortForwarder in which it would not respect the port to listen on. #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
instead it always used the ephemeral one.
When constructing the port forwarder this last paramater:
Was not at all used, and instead we always listened on port
0
aka start listening on a free port, even in the case the user setlisteningPort
to a value.With this change if you call that ctor with
listeningPort = 123
it WILL now listen on port 123.This is an issue when using the port forwarder ad hoc e.g. in a command line program.
How to review this PR
Quality ✔️
Pre-requisites