Use environment variable for core | install item title#58
Open
jbillo wants to merge 1 commit intoOefenweb:masterfrom
Open
Use environment variable for core | install item title#58jbillo wants to merge 1 commit intoOefenweb:masterfrom
jbillo wants to merge 1 commit intoOefenweb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a WordPress installation in my list of
wordpress_installsthat has a single-quote character'in the title. An example would be something like:Currently this fails as the
wp-cli core installcommand is invoked with the Ansible{{ item.item.title }}variable in single quotes, making the shell command unbalanced (https://github.com/Oefenweb/ansible-wordpress/blob/master/tasks/core.yml#L53).Rather than using
regex_replaceorreplaceon the string, as a workaround, set theITEM_TITLEenvironment variable, then use it in a double-quoted string. This should preserve behaviour of single quotes, apostrophes, and$characters.Tested with the following config:
Resulting in the following database value:
I would be amenable to changing the environment variable name if there is a preference, but it should also only persist for this particular task in
coreas per the Ansible documentation (https://docs.ansible.com/ansible/latest/user_guide/playbooks_environment.html).