cleanup: breaking up expected withdrawals into smaller functions #15194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
potuz
previously approved these changes
Apr 17, 2025
terencechain
previously approved these changes
Apr 17, 2025
james-prysm
commented
May 7, 2025
| } | ||
| processedPartialWithdrawalsCount++ | ||
| } | ||
| return withdrawals, withdrawalIndex, processedPartialWithdrawalsCount, nil |
There was a problem hiding this comment.
this is pretty ugly returning so many values
james-prysm
commented
May 7, 2025
| } | ||
|
|
||
| func (b *BeaconState) processPendingPartialWithdrawals(withdrawals []*enginev1.Withdrawal) ([]*enginev1.Withdrawal, uint64, uint64, error) { | ||
| withdrawalIndex := b.nextWithdrawalIndex |
There was a problem hiding this comment.
this part is redefining already existing variables , this is safe for this function but must be considered for future changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
just some cleanup review feedback that I'm breaking out into a separate PR
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements