Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio #335

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add audio #335

wants to merge 7 commits into from

Conversation

mkaszewiak
Copy link

Copy link
Contributor

Learn Build status updates of commit 90a494b:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@twsouthwick twsouthwick requested a review from Copilot March 31, 2025 17:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new documentation page explaining how to add audio to a slide in a presentation using the Open XML SDK.

  • Introduces a new markdown file with detailed instructions and code snippet references for both C# and Visual Basic.
  • Provides an XML schema fragment and sample code explanations to support the tutorial content.
Comments suppressed due to low confidence (1)

docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md:8

  • Consider correcting the article; 'a audio' should be 'an audio' or simply 'audio' to improve grammatical accuracy in the title.
title: 'How to: Add a audio to a slide in a presentation'

Comment on lines 123 to 124
All other elements such Offset(`<off/>`), Stretch(`<stretch/>`), fillRectangle(`<fillRect/>`), are appended to the ShapeProperties(`<spPr/>`) and ShapeProperties are appended to the Picture element(`<pic/>`). Finally the picture element that incudes audio is added to the ShapeTree(`<sp/>`) of the slide.

Copy link
Preview

Copilot AI Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo detected: 'incudes' should be corrected to 'includes'.

Suggested change
All other elements such Offset(`<off/>`), Stretch(`<stretch/>`), fillRectangle(`<fillRect/>`), are appended to the ShapeProperties(`<spPr/>`) and ShapeProperties are appended to the Picture element(`<pic/>`). Finally the picture element that incudes audio is added to the ShapeTree(`<sp/>`) of the slide.
All other elements such Offset(`<off/>`), Stretch(`<stretch/>`), fillRectangle(`<fillRect/>`), are appended to the ShapeProperties(`<spPr/>`) and ShapeProperties are appended to the Picture element(`<pic/>`). Finally the picture element that includes audio is added to the ShapeTree(`<sp/>`) of the slide.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

api_type:
- schema
ms.assetid: 403abe97-7ab2-40ba-92c0-d6312a6d10c8
title: 'How to: Add a audio to a slide in a presentation'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'How to: Add a audio to a slide in a presentation'
title: 'How to: Add audio to a slide in a presentation'

unless you want something like "an audio file"


## Getting a Presentation Object

In the Open XML SDK, the `PresentationDocument` class represents a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #334

@twsouthwick
Copy link
Collaborator

program.cs is being identified as a binary file

Copy link
Collaborator

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean a few of these things up

Copy link
Contributor

Learn Build status updates of commit 577977c:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 2b31557:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 477f8fd:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@mkaszewiak mkaszewiak requested a review from twsouthwick April 1, 2025 13:31
Copy link
Contributor

Learn Build status updates of commit f459e1e:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 5da2f65:

✅ Validation status: passed

File Status Preview URL Details
docs/presentation/how-to-add-an-audio-to-a-slide-in-a-presentation.md ✅Succeeded
samples/presentation/add_audio/cs/add_audio_cs.csproj ✅Succeeded
samples/presentation/add_audio/cs/Program.cs ✅Succeeded
samples/presentation/add_audio/vb/add_audio_vb.vbproj ✅Succeeded
samples/presentation/add_audio/vb/Program.vb ✅Succeeded
samples/samples.sln ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants