Skip to content

fix: stabilize mermaid title width and video autolinks - #155

Closed
starSumi wants to merge 1 commit into
OlaProeis:0.3.1-experimentalfrom
starSumi:fix/runtime-test-mermaid-videoembed-experimental
Closed

fix: stabilize mermaid title width and video autolinks#155
starSumi wants to merge 1 commit into
OlaProeis:0.3.1-experimentalfrom
starSumi:fix/runtime-test-mermaid-videoembed-experimental

Conversation

@starSumi

Copy link
Copy Markdown
Contributor

Summary

  • ignore whitespace-only text nodes when recognizing bare YouTube URL paragraphs
  • round subgraph title minimum width upward to avoid float-boundary assertion failures
  • keep this PR scoped to the mermaid + video_embed runtime baseline slice

Validation

  • cargo check --locked --quiet
  • cargo test --locked document_parses_bare_youtube_url_paragraph -- --nocapture
  • cargo test --locked bare_non_youtube_url_stays_paragraph -- --nocapture
  • cargo test --locked video_embed_in_paragraph_with_other_text_stays_paragraph -- --nocapture
  • cargo test --locked test_subgraph_title_width_expansion -- --nocapture
  • cargo test --locked test_subgraph_short_title_no_extra_expansion -- --nocapture
  • git diff --check

Explicitly deferred

  • state::tests::test_recovery_identity_original_bleeding_repro_rejected
  • state::tests::test_recovery_identity_path_mismatch_rejected
  • vcs::git::tests::test_git_service_untracked_file

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6539e131-a5b2-4c7b-9403-80ee11d96558

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OlaProeis

Copy link
Copy Markdown
Owner

Thanks for splitting these into focused PRs, and for all the great work on the experimental branch. Really helpful.

We merged #156 and #157 into \

@OlaProeis

Copy link
Copy Markdown
Owner

Thanks for splitting these into focused PRs, and for all the great work on the experimental branch. Really helpful.

We merged #156 and #157 into 0.3.1-experimental just now. #156 was exactly what we needed for Linux CI with wry/WebView, and #157 fits nicely with the local path handling we already had for images.

We are holding off on merging #155 for the moment, mainly on the video autolink side. On our branch we recently moved to explicit {{video URL}} syntax only, so bare YouTube URLs stay as normal clickable links rather than auto-embedding. Your whitespace fix in extract_bare_youtube_url is sensible, but it goes in a different direction than what we shipped.

Before we decide how to handle that, I wanted to ask what you have in mind for video embeds longer term. Should Ferrite auto-detect YouTube links in a paragraph and embed them? Only when wrapped in {{video ...}}? Or also support something like an HTML video tag? Happy to align on one approach rather than flip-flopping.

The mermaid title width ceil fix in #155 looks good on its own. We may cherry-pick that part separately if that works for you.

Thanks again.

@starSumi

Copy link
Copy Markdown
Contributor Author

Aligned with your direction on video embeds: keep explicit {{video URL}} only, and leave bare YouTube URLs as normal links. I split the Mermaid title-width ceil fix into a separate minimal PR so it can be cherry-picked independently without mixing in the video policy change.

@OlaProeis

Copy link
Copy Markdown
Owner

Closing this one out. The mermaid subgraph title width fix landed via #159, and the rest of your recent work (#156, #157, #158, #160) is merged into 0.3.1-experimental now.

We are keeping the video side as explicit {{video URL}} only for now, so the bare YouTube autolink change here does not match where we landed. Happy to revisit once we align on embed policy.

Thanks again for all the focused PRs and the solid work on the experimental branch.

@OlaProeis OlaProeis closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants