fix: stabilize mermaid title width and video autolinks - #155
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for splitting these into focused PRs, and for all the great work on the experimental branch. Really helpful. We merged #156 and #157 into 0.3.1-experimental just now. #156 was exactly what we needed for Linux CI with wry/WebView, and #157 fits nicely with the local path handling we already had for images. We are holding off on merging #155 for the moment, mainly on the video autolink side. On our branch we recently moved to explicit {{video URL}} syntax only, so bare YouTube URLs stay as normal clickable links rather than auto-embedding. Your whitespace fix in extract_bare_youtube_url is sensible, but it goes in a different direction than what we shipped. Before we decide how to handle that, I wanted to ask what you have in mind for video embeds longer term. Should Ferrite auto-detect YouTube links in a paragraph and embed them? Only when wrapped in {{video ...}}? Or also support something like an HTML video tag? Happy to align on one approach rather than flip-flopping. The mermaid title width ceil fix in #155 looks good on its own. We may cherry-pick that part separately if that works for you. Thanks again. |
|
Aligned with your direction on video embeds: keep explicit |
|
Closing this one out. The mermaid subgraph title width fix landed via #159, and the rest of your recent work (#156, #157, #158, #160) is merged into We are keeping the video side as explicit Thanks again for all the focused PRs and the solid work on the experimental branch. |
Summary
Validation
Explicitly deferred