Skip to content

Commit

Permalink
Merge pull request #102 from Olf0/master
Browse files Browse the repository at this point in the history
Final push for v1.3.1
  • Loading branch information
Olf0 authored Oct 27, 2020
2 parents 7e5f669 + 9ac41b3 commit fb1fe7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion RPM-dependencies_Git-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ common "head" branch -------------------------------> release branch non-A, non-
The process can also be partially executed, i.e. only from a "feature branch" to its "release branches", but always obey the second bullet point ("forward only")!

#### Implementation
For *crypto-sdcard*, starting with versions 1.3.1, ...
For *crypto-sdcard*, starting with version 1.3.1, ...
* the [release string format carries two feature specific identifiers in its second field](https://github.com/Olf0/crypto-sdcard/blob/master/rpm/crypto-sdcard.spec#L7): {*regular*, *qcrypto*} and *sfosABC* (currently with *ABC* out of {*321*, *340*}).<br />
Each of those two may be used to distinguish between more than two features / properties in the future: By defining more SailfishOS releases to differentiate for, or by extending the list of specified appendices denoting mutually ecxlusive features / properties of a target system.<br />
Additionally a third (or more) distinguishing identifier ("differentiator") may be defined, but that would require some visual separator for more sub-fields in the second field of the release string other than the dot (`.`) and dash (`-`, minus, hyphen), or introducing a new, third field (moving the extant one to the fourth position). Both possibilities are not nice, e.g. a `+` as a separator conflicts with the set of allowed characters for git tags (at least at Github), the tilde (`~`) is also likely to cause issues, only the underscore (`_`) likely works (but is visually the ugliest option, IMO), and four or even more fields separated by dots in the release string may infringe some convention. Hence I will try to avoid this, although the `_` or another, additional field (i.e., not a sub-field of the second field) might provide viable paths for extending this scheme.
Expand Down
2 changes: 1 addition & 1 deletion rpm/crypto-sdcard.spec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Requires: sailfish-version < 3.4.0
Requires: cryptsetup >= 1.4.0
# Necessary counter-dependency to https://github.com/Olf0/crypto-sdcard/blob/qcrypto/rpm/crypto-sdcard.spec#L40
Conflicts: kernel-adaptation-sbj
# For details see requirement 3 at https://github.com/Olf0/crypto-sdcard/blob/master/RPM-dependencies_Git-workflow.md#requirements
# ..., see requirement 3 at https://github.com/Olf0/crypto-sdcard/blob/master/RPM-dependencies_Git-workflow.md#requirements
Conflicts: crypto-sdcard_sbj

%description
Expand Down

0 comments on commit fb1fe7b

Please sign in to comment.