Dev/nissekaka directx by nissekaka · Pull Request #33 · OlleKReutercrona/RuneForge

nissekaka · 2026-04-29T20:01:01Z

Bug
Feature

Description:

Added DirectX 11 and DirectX 12 base. Intention is to create an API that doesn't care what's underneath.

…ok into any rendering pipeline.

… into develop

OlleKReutercrona

Vi gör ett försök att flytta d3dx12.h till att vara en submodule istället samt gör DX11 samt DX12 till att vara av en gemensam abstraktionstyp som har samma API. På det sättet kan vi använda byggflaggor för att bestämma vilket API vi vill använda och till och med byta till metal om vi vill bygga för OSX i framtiden ;)

Copilot

Pull request overview

Adds a foundational DirectX 11/12 rendering layer under a common IRenderer interface, and wires renderer creation into the engine so the underlying graphics API can be swapped without changing higher-level code.

Changes:

Link DirectX 11/12 system libraries in the Core premake project.
Add IRenderer plus initial DX11 and DX12 renderer implementations (basic clear + present).
Update Engine to own an IRenderer and delegate Render() calls to it.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Source/Core/premake5.lua	Links `d3d11`/`d3d12` to support the new renderer implementations.
Source/Core/Graphics/d3dx12.h	Adds the D3DX12 helper header used by the DX12 implementation.
Source/Core/Graphics/IRenderer.h	Introduces the renderer abstraction used by Engine.
Source/Core/Graphics/DX12.h	Declares the DX12 renderer implementation and its core D3D12 members.
Source/Core/Graphics/DX12.cpp	Implements DX12 init/render path (swapchain, RTVs, command list, fence).
Source/Core/Graphics/DX11.h	Declares the DX11 renderer implementation.
Source/Core/Graphics/DX11.cpp	Implements DX11 init/render path (device+swapchain, RTV, viewport).
Source/Core/Engine/Engine.h	Adds `GraphicsAPI`, `mRenderer`, and renderer ownership to Engine.
Source/Core/Engine/Engine.cpp	Instantiates DX11/DX12 renderer and delegates Engine rendering to it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-05-01T07:39:00Z

+	// Ensure GPU is finished before destroying resources
+	mFenceValue++;
+	HRESULT hr = mCommandQueue->Signal(mFence.Get(), mFenceValue);
+
+	if (mFence->GetCompletedValue() < mFenceValue) {
+		hr = mFence->SetEventOnCompletion(mFenceValue, mFenceEvent);
+		WaitForSingleObject(mFenceEvent, INFINITE);
+	}
+	CloseHandle(mFenceEvent);


DX12 destructor assumes initialization succeeded and unconditionally dereferences mCommandQueue/mFence (and closes mFenceEvent). If Init was never called or threw part-way through, this can null-deref and/or call CloseHandle on an invalid handle. Guard cleanup with mInitialized and/or nullptr checks, and only Signal/SetEvent/CloseHandle when the corresponding objects/handle are valid.

Suggested change

// Ensure GPU is finished before destroying resources

mFenceValue++;

HRESULT hr = mCommandQueue->Signal(mFence.Get(), mFenceValue);

if (mFence->GetCompletedValue() < mFenceValue) {

hr = mFence->SetEventOnCompletion(mFenceValue, mFenceEvent);

WaitForSingleObject(mFenceEvent, INFINITE);

}

CloseHandle(mFenceEvent);

// Only perform GPU synchronization/handle cleanup if initialization completed

// and the corresponding resources were actually created.

if (!mInitialized)

return;

if (mCommandQueue && mFence) {

// Ensure GPU is finished before destroying resources

mFenceValue++;

HRESULT hr = mCommandQueue->Signal(mFence.Get(), mFenceValue);

if (SUCCEEDED(hr) && mFence->GetCompletedValue() < mFenceValue && mFenceEvent) {

hr = mFence->SetEventOnCompletion(mFenceValue, mFenceEvent);

if (SUCCEEDED(hr))

WaitForSingleObject(mFenceEvent, INFINITE);

}

}

if (mFenceEvent)

CloseHandle(mFenceEvent);

Copilot · 2026-05-01T07:39:00Z

+	// Reset allocator and command list each frame
+	HRESULT hr = mCommandAllocator->Reset();
+	hr = mCommandList->Reset(mCommandAllocator.Get(), nullptr);
+


HRESULTs returned from Reset/Close/Present/Signal/SetEventOnCompletion are assigned to hr but never validated. When these fail (e.g., device removed, invalid state, allocator still in use), the renderer will continue issuing commands with undefined behavior. Check each HRESULT and fail fast (throw/log/return) so errors are surfaced and you don't proceed with an invalid command list or swap chain state.

Copilot · 2026-05-01T07:39:00Z

+void RF::DX12::CreateSwapChain(const HWND hwnd, const uint32_t width, const uint32_t height) {
+	ComPtr<IDXGIFactory4> factory;
+	HRESULT hr = CreateDXGIFactory1(IID_PPV_ARGS(&factory));
+	if (FAILED(hr))
+		throw std::runtime_error("Failed to create DXGI Factory");


CreateSwapChain creates a new DXGI factory via CreateDXGIFactory1 even though Init already created a factory with debug flags. This duplicates work and (in _DEBUG) can drop DXGI debug factory behavior. Consider passing the factory created in Init into CreateSwapChain or storing it as a member and reusing it.

Copilot · 2026-05-01T07:39:01Z

+	D3D11CreateDeviceAndSwapChain(
+		nullptr,
+		D3D_DRIVER_TYPE_HARDWARE,
+		nullptr,
+		swapCreateFlags,
+		nullptr,
+		0,
+		D3D11_SDK_VERSION,
+		&scd,
+		&pSwap,
+		&pDevice,
+		nullptr,
+		&pContext
+	);


The return value from D3D11CreateDeviceAndSwapChain is ignored. If device/swapchain creation fails, subsequent calls will dereference null ComPtrs (pSwap/pDevice/pContext) and crash, while mInitialized is still set to true. Capture the HRESULT and throw/return an error when it fails.

Copilot · 2026-05-01T07:39:01Z

+	Microsoft::WRL::ComPtr<ID3D11Resource> pBackBuffer;
+	pSwap->GetBuffer(0u, __uuidof(ID3D11Resource), &pBackBuffer);
+	pDevice->CreateRenderTargetView(pBackBuffer.Get(), nullptr, &pDefaultTarget);


GetBuffer/CreateRenderTargetView results are not checked. If the swap chain buffer retrieval or RTV creation fails, pDefaultTarget may remain null and later ClearRenderTargetView will crash. Please check HRESULTs here and surface an initialization failure instead of continuing.

…working state

…rcrona/RuneForge into dev/nissekaka-directx # Conflicts: # Source/Core/Graphics/DX11.h

OlleKReutercrona · 2026-05-10T13:29:35Z

+	switch (mGraphicsAPI) {
+		case GraphicsAPI::DirectX11:
+			mRenderer = std::make_unique<RF::DX11>(mWindow->GetHWND(), windowParams.width, windowParams.height);
+			break;
+		case GraphicsAPI::DirectX12:
+			mRenderer = std::make_unique<RF::DX12>(mWindow->GetHWND(), windowParams.width, windowParams.height);
+			break;
+	}


Det här borde vara en preprocessor check i och med att vi aldrig kommer byta api i runtime

Suggested change

switch (mGraphicsAPI) {

case GraphicsAPI::DirectX11:

mRenderer = std::make_unique<RF::DX11>(mWindow->GetHWND(), windowParams.width, windowParams.height);

break;

case GraphicsAPI::DirectX12:

mRenderer = std::make_unique<RF::DX12>(mWindow->GetHWND(), windowParams.width, windowParams.height);

break;

}

#ifdef DX11

mRenderer = std::make_unique<RF::DX11>(mWindow->GetHWND(), windowParams.width, windowParams.height);

#elif DX12

mRenderer = std::make_unique<RF::DX12>(mWindow->GetHWND(), windowParams.width, windowParams.height);

#endif

nissekaka added 2 commits April 29, 2026 21:52

Added base for DX11 and DX12. Intention is to make an API that can ho…

6ef53fc

…ok into any rendering pipeline.

Merge branch 'develop' of https://github.com/OlleKReutercrona/RuneForge…

1cc002a

… into develop

nissekaka requested review from OlleKReutercrona and Copilot and removed request for Copilot April 29, 2026 20:01

Copilot started reviewing on behalf of nissekaka April 29, 2026 20:01 View session

OlleKReutercrona reviewed Apr 30, 2026

View reviewed changes

Comment thread Source/Core/Graphics/DX11.cpp Outdated

Comment thread Source/Core/Engine/Engine.h Outdated

Comment thread Source/Core/Engine/Engine.cpp Outdated

Comment thread Source/Core/Graphics/DX11.cpp

Added IRenderer to abstract Graphics engines.

d5024c4

Copilot AI review requested due to automatic review settings May 1, 2026 07:32

Copilot started reviewing on behalf of nissekaka May 1, 2026 07:32 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Removed Init functions to make sure these objects are never in a non-…

ccbaa84

…working state

OlleKReutercrona closed this May 1, 2026

OlleKReutercrona reopened this May 1, 2026

OlleKReutercrona closed this May 1, 2026

OlleKReutercrona reopened this May 1, 2026

nissekaka added 3 commits May 2, 2026 08:56

Naming convention + HRESULT

e64d2a3

Naming convention + HRESULT

9429e74

Merge branch 'dev/nissekaka-directx' of https://github.com/OlleKReute…

d939312

…rcrona/RuneForge into dev/nissekaka-directx # Conflicts: # Source/Core/Graphics/DX11.h

OlleKReutercrona reviewed May 10, 2026

View reviewed changes

nissekaka added 2 commits May 10, 2026 17:25

Removed HRESULT hr where it didn't make sense

d01a584

DX11 create params

93b4ac9

OlleKReutercrona approved these changes May 10, 2026

View reviewed changes

OlleKReutercrona closed this May 12, 2026

OlleKReutercrona reopened this May 12, 2026

Merge branch 'develop' into dev/nissekaka-directx

94ffaf3

nissekaka merged commit a059218 into develop May 12, 2026
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev/nissekaka directx#33

Dev/nissekaka directx#33
nissekaka merged 10 commits into
developfrom
dev/nissekaka-directx

nissekaka commented Apr 29, 2026

Uh oh!

OlleKReutercrona left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

OlleKReutercrona May 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nissekaka commented Apr 29, 2026

Description:

Uh oh!

OlleKReutercrona left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

OlleKReutercrona May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants